Draft: Check and fix for podman network_backend consistency when embedding containers (HMS-8783)#1365
Draft: Check and fix for podman network_backend consistency when embedding containers (HMS-8783)#1365thozza wants to merge 4 commits intoosbuild:mainfrom
network_backend consistency when embedding containers (HMS-8783)#1365Conversation
thozza
force-pushed
the
el9-podman-network_backend-fix
branch
from
0cf9369 to
551bc50
Compare
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
Really nice! Thank.
The last commit message is a bit too long. Can you make it shorter?
Will do. I hoped that GH will mark this PR as a Draft. 😇 My plan is first to see where the consistency check fails, before pushing any fix for RHEL-9. |
thozza
force-pushed
the
el9-podman-network_backend-fix
branch
2 times, most recently
from
d27bc35 to
4b9ecd5
Compare
thozza
force-pushed
the
el9-podman-network_backend-fix
branch
from
4b9ecd5 to
d647bc5
Compare
It turns out that jq is not installed by default on RHEL-8 images and therefore no checks were run on RHEL-8. Also extend the check script to fail in case jq is not installed, to prevent it from silently passing. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Extend the `all-customizations.json` config to embed a container in the image. Extend the `base-host-check.sh` to verify that a container image is present on the booted system in case it was specified in the BP. Explicitly install podman, which is required by the check. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
When embedding containers into images, certain versions of podman may consider them as a sign of system upgrade or migration and may fall back to using `cni` network_backend for backward compatibility even though it should use its default. Since we embed containers as root, this manifests as different network_backend being used for rootfull and rootless podman. Add a check to verify that the network_backend is the same for rootfull and rootless podman when embedding container into the image. More information in: https://docs.podman.io/en/v4.2/markdown/podman-network.1.html Signed-off-by: Tomáš Hozza <thozza@redhat.com>
…ions Be consistent and don't rely on the global `config` variable in check functions and instead use a local `config_file` variable and error if not config is provided to the check function. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
force-pushed
the
el9-podman-network_backend-fix
branch
from
d647bc5 to
341bda0
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
Do we still want this? EDIT: Nvm, noticed you un-staled it. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
thozza
changed the title
network_backend consistency when embedding containersnetwork_backend consistency when embedding containers (HMS-8783)
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
boop |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
2 participants
WIP